Skip to content

parsing failure of invalid author/committer line - missing space before email #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yuja opened this issue Jul 3, 2024 · 3 comments · Fixed by #1439
Closed

parsing failure of invalid author/committer line - missing space before email #1438

yuja opened this issue Jul 3, 2024 · 3 comments · Fixed by #1439
Assignees
@Byron
Labels
acknowledged an issue is accepted as shortcoming to be fixed

Comments

@yuja
Copy link
Contributor

yuja commented Jul 3, 2024 •
edited
Loading

Current behavior 😯

Apparently, gix can't parse the following commit:
LibreOffice/core@eaa4e44

% git cat-file commit eaa4e44cfee19f81a3a3d41982263a3f09e23f06  
tree 220738fd4199e95a2b244465168366a73ebdf271
parent 209fbe2d632761b30b7b17422914e11b93692833
author Gregor Hartmann<gh <Gregor Hartmann<[email protected]>> 1282910542 +0200
committer Gregor Hartmann<gh <Gregor Hartmann<[email protected]>> 1282910542 +0200

build breakers

Originally reported to jj-vcs/jj#4008

Expected behavior 🤔

Recover from parsing error by default, or add option to do so? This is similar to #950 and #1322.

Git behavior

% git show eaa4e44cfee19f81a3a3d41982263a3f09e23f06
commit eaa4e44cfee19f81a3a3d41982263a3f09e23f06
Author: Gregor Hartmann <gh <Gregor Hartmann<[email protected]>
Date:   Fri Aug 27 14:02:22 2010 +0200
...

BTW, git fsck reports many errors in this repository. There might be other invalid patterns that gix can't parse.

Steps to reproduce 🕹

No response
@yuja yuja mentioned this issue Jul 3, 2024
Closed
@Byron Byron self-assigned this Jul 3, 2024
@Byron Byron added the acknowledged an issue is accepted as shortcoming to be fixed label Jul 3, 2024
@Byron
Copy link
Member

Byron commented Jul 3, 2024

Thanks for reporting, I am looking into it right now.

The handling of objects like these will probably remain reactive, i.e. depends on bug reports, but I will usually be fixing these the same day.

Byron added a commit that referenced this issue Jul 3, 2024
@Byron
reproduce failure when parsing malformed commit (#1438)
d0c8123 
Note that Git can parse it.

It's notable that it parses the name as `Gregor Hartmann`
and the email as `gh <Gregor Hartmann<[email protected]`,
while the author/commiter lines are
`Gregor Hartmann<gh <Gregor Hartmann<[email protected]>>`
Byron added a commit that referenced this issue Jul 3, 2024
@Byron
reproduce failure when parsing malformed commit (#1438)
6c5861d 
Note that Git can parse it.

It's notable that it parses the name as `Gregor Hartmann`
and the email as `gh <Gregor Hartmann<[email protected]`,
while the author/commiter lines are
`Gregor Hartmann<gh <Gregor Hartmann<[email protected]>>`
Byron added a commit that referenced this issue Jul 3, 2024
@Byron
fix: make actor parsing even more lenient (#1438)
83eae43
Byron added a commit that referenced this issue Jul 3, 2024
@Byron
fix: make actor parsing even more lenient (#1438)
40be214
@Byron Byron linked a pull request Jul 3, 2024 that will close this issue
reproduce failure when parsing malformed commit (#1438) #1439
Merged
2 tasks
@Byron
Copy link
Member

Byron commented Jul 3, 2024

gix-actor contains the fix, and gix-object was also updated for good measure. But updating gix-actor should do the trick.

Minion3665 added a commit to Minion3665/jj that referenced this issue Jul 3, 2024
@Minion3665
cargo: bump gix-actor to v0.31.4
a8ed23b 
Gitoxide, which is used to parse git commits, previously failed to parse
some malformed author/committer lines.

In 0.31.4, this parsing was made more lenient so as to better match
Git's parsing and avoid breaking on "in-the-wild" repositories such as
https://github.com/LibreOffice/core

Refs: GitoxideLabs/gitoxide#1438
Fixes: jj-vcs#4008
@Minion3665 Minion3665 mentioned this issue Jul 3, 2024
Merged
4 tasks
emilazy pushed a commit to jj-vcs/jj that referenced this issue Jul 3, 2024
@Minion3665 @emilazy
cargo: bump gix-actor to v0.31.4
5de0ae8 
Gitoxide, which is used to parse git commits, previously failed to parse
some malformed author/committer lines.

In 0.31.4, this parsing was made more lenient so as to better match
Git's parsing and avoid breaking on "in-the-wild" repositories such as
https://github.com/LibreOffice/core

Refs: GitoxideLabs/gitoxide#1438
Fixes: #4008
@yuja
Copy link
Contributor Author

yuja commented Jul 4, 2024

Thanks for the quick fix!

LuaKT pushed a commit to LMonitor/gitoxide that referenced this issue Aug 20, 2024
@Byron @LuaKT
reproduce failure when parsing malformed commit (GitoxideLabs#1438)
bc364c0 
Note that Git can parse it.

It's notable that it parses the name as `Gregor Hartmann`
and the email as `gh <Gregor Hartmann<[email protected]`,
while the author/commiter lines are
`Gregor Hartmann<gh <Gregor Hartmann<[email protected]>>`
LuaKT pushed a commit to LMonitor/gitoxide that referenced this issue Aug 20, 2024
@Byron @LuaKT
fix: make actor parsing even more lenient (GitoxideLabs#1438)
cb0aa12
Byron added a commit to pierrechevalier83/gitoxide that referenced this issue Apr 5, 2025
@Byron
Bring back test-case to show how trailing slashes are handled (Gitox…
ce6c75d 
…ideLabs#1438)
Byron added a commit to pierrechevalier83/gitoxide that referenced this issue Apr 5, 2025
@Byron
Bring back test-case to show how trailing slashes are handled (Gitox…
39e35a3 
…ideLabs#1438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Byron Byron

Labels
acknowledged an issue is accepted as shortcoming to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reproduce failure when parsing malformed commit (#1438) GitoxideLabs/gitoxide
2 participants
@Byron @yuja