Skip to content

More cargo-deny maintenance #1927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2025
Merged

More cargo-deny maintenance #1927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3cfd7fa
Delist LicenseRef-ring, as ring no longer uses it
EliahKagan Apr 5, 2025
f8fb226
Use "reason" field to explain ignored advisory
EliahKagan Apr 5, 2025
7ad29e6
Reorder `with` subkeys in `cargo-deny-*` CI for clarity
EliahKagan Apr 5, 2025
67d9bf4
On CI, have `cargo deny` allow RUSTSEC-2025-0021 via gix-testtools
EliahKagan Apr 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,10 +344,28 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: EmbarkStudios/cargo-deny-action@v2
- name: Install tomlq
run: |
# The runner already has the `yq` command but not its associated `tomlq` command.
sudo apt-get update
sudo apt-get install yq
- name: Strict check, but omit gix-testtools
uses: EmbarkStudios/cargo-deny-action@v2
with:
command: check advisories
arguments: --workspace --all-features --exclude gix-testtools
- name: Configure less strict check
run: |
filter='.advisories.ignore += [
{ id: "RUSTSEC-2025-0021", reason: "gix-testtools can’t upgrade from old gix-features yet" }
]'
tomlq "$filter" deny.toml --toml-output > deny-but-ignore-RUSTSEC-2025-0021.toml
- name: Less strict check, but include gix-testtools
uses: EmbarkStudios/cargo-deny-action@v2
with:
arguments: --workspace --all-features
command: check advisories
arguments: --workspace --all-features
command-arguments: --config deny-but-ignore-RUSTSEC-2025-0021.toml

cargo-deny:
runs-on: ubuntu-latest
Expand All @@ -356,8 +374,8 @@ jobs:
- uses: actions/checkout@v4
- uses: EmbarkStudios/cargo-deny-action@v2
with:
arguments: --workspace --all-features
command: check bans licenses sources
arguments: --workspace --all-features

wasm:
name: WebAssembly
Expand Down
4 changes: 1 addition & 3 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@
# https://embarkstudios.github.io/cargo-deny/checks/advisories/cfg.html
[advisories]
ignore = [
# `paste` - macro crate without replacement
"RUSTSEC-2024-0436"
{ id = "RUSTSEC-2024-0436", reason = "`paste` - macro crate without replacement" },
]


Expand All @@ -29,7 +28,6 @@ allow = [
"MIT",
"MIT-0",
"ISC",
"LicenseRef-ring",
"OpenSSL",
"Zlib",
"MPL-2.0",
Expand Down
Loading