index reading #294
Merged
index reading #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that in-code we must make sufficiently clear where a particular fixture is coming from, or we name it after the test and file right away.
It deals with comparing items from the work tree and the index, and is generally what makes use of exclude specificiations.
It should be easy enough to learn from git tests to generate whichever kind of index we need.
This is now sufficiently well implemented in the standard library.
It's sufficiently well supported using the standard library now.
For now the data structure is just 'as-written' and we see what needs to change there as we have to maintain it.
…even though it doesn't work yet as the flags don't pass an assertion.
Now it works more, but for some reason we don't see the trailer checksum. It seems extensions consume too much.
This leads to the first seemingly correct parsing of simple index files.
It's here only so that we can share the code across crates, for now without any feature toggles.
Unfortunately we are a little more inefficient there as we have to copy the shared portion into a buffer before we can use these bytes to extend the backing storage with. Fair enough, it's most definitely not measurable.
Now for actually using it, that needs some work.
This allows more delicate threading control like is required for the index.
This iterator makes possible identifies results using a sequence id and returns only consecutive items. Use it to collect unordered results produced by threads. It's advantage to collecting yourself and sorting is the potential for a smaller memory footprint of in-flight results, one doesn't have to collect them all for ordering, necessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks
Related to #293