Skip to content

fix: test & review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2021
Merged

fix: test & review #1

merged 1 commit into from
Oct 5, 2021

Conversation

Moumouls
Copy link

@Moumouls Moumouls commented Oct 5, 2021

New Pull Request Checklist

Issue Description

Related issue: FILL_THIS_OUT

Approach

TODOs before merging

  • Add test cases
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK
  • ...

@Moumouls Moumouls changed the base branch from master to pr-migrations October 5, 2021 17:45
@Moumouls Moumouls mentioned this pull request Oct 5, 2021
Merged
6 tasks
sadortun
sadortun approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@sadortun sadortun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

Please Resolve discussions in upstream PR ( if you can't, just add a comment ) and I'll close them.

@sadortun sadortun merged commit 426857f into GoPlan-Finance:pr-migrations Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadortun sadortun sadortun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Moumouls @sadortun