Skip to content

Issue 6810 type annotations for sqlalchemy.sql.sqltypes #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Issue 6810 type annotations for sqlalchemy.sql.sqltypes #7

wants to merge 7 commits into from

Conversation

maxamly
Copy link

@maxamly maxamly commented Jan 18, 2023

Description

An attempt to annotate lib/sqlalchemy/sql/sqltypes.py with type hints (issue sqlalchemy#6810)

Checklist

This pull request is:

  • A documentation / typographical error fix
    • Good to go, no issue or tests are needed
  • A short code fix
    • please include the issue number, and create an issue if none exists, which
      must include a complete example of the issue. one line code fixes without an
      issue and demonstration will not be accepted.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests. one line code fixes without tests will not be accepted.
  • A new feature implementation
    • please include the issue number, and create an issue if none exists, which must
      include a complete example of how the feature would look.
    • Please include: Fixes: #<issue number> in the commit message
    • please include tests.

Have a nice day!

@maxamly maxamly self-assigned this Jan 18, 2023
@maxamly maxamly force-pushed the issue_6810_type_annotate_sqlalchemy.sql.sqltypes branch from 95df1c5 to 17ff7c0 Compare January 29, 2023 22:32
@maxamly maxamly requested review from dzmitar, a user and jazzthief January 31, 2023 14:43
@maxamly maxamly marked this pull request as ready for review January 31, 2023 14:43
@jazzthief
Copy link

@mlatysh Github says there's a small merge conflict in the imports. Could you please resolve it?

@maxamly maxamly force-pushed the issue_6810_type_annotate_sqlalchemy.sql.sqltypes branch from 86ad684 to c45e456 Compare February 1, 2023 13:52
@maxamly maxamly marked this pull request as draft February 6, 2023 08:59
@maxamly maxamly removed request for dzmitar, jazzthief and a user February 6, 2023 08:59
@maxamly maxamly force-pushed the issue_6810_type_annotate_sqlalchemy.sql.sqltypes branch 2 times, most recently from 447c2b2 to fce2b1d Compare February 8, 2023 21:23
@maxamly maxamly marked this pull request as ready for review February 8, 2023 21:30
@maxamly maxamly force-pushed the issue_6810_type_annotate_sqlalchemy.sql.sqltypes branch from fce2b1d to 75db9ee Compare March 23, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maxamly maxamly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxamly @jazzthief