Skip to content

Conversation

@mhansen
Copy link
Collaborator

@mhansen mhansen commented Dec 3, 2025

Fixes #120

error: this `impl` can be derived
  --> src/unzip/seekable_http_reader.rs:54:1
   |
54 | / impl Default for AccessPattern {
55 | |     fn default() -> Self {
56 | |         Self::RandomAccess
57 | |     }
58 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#derivable_impls
   = note: `-D clippy::derivable-impls` implied by `-D clippy::all`
   = help: to override `-D clippy::all` add `#[allow(clippy::derivable_impls)]`
help: replace the manual implementation with a derive attribute and mark the default variant
   |
45 + #[derive(Default)]
46 ~ pub(crate) enum AccessPattern {
47 |     /// We expect accesses all over the file.
48 ~     #[default]
49 ~     RandomAccess,
   |

```
error: this `impl` can be derived
  --> src/unzip/seekable_http_reader.rs:54:1
   |
54 | / impl Default for AccessPattern {
55 | |     fn default() -> Self {
56 | |         Self::RandomAccess
57 | |     }
58 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#derivable_impls
   = note: `-D clippy::derivable-impls` implied by `-D clippy::all`
   = help: to override `-D clippy::all` add `#[allow(clippy::derivable_impls)]`
help: replace the manual implementation with a derive attribute and mark the default variant
   |
45 + #[derive(Default)]
46 ~ pub(crate) enum AccessPattern {
47 |     /// We expect accesses all over the file.
48 ~     #[default]
49 ~     RandomAccess,
   |
```
@yangsharon-chromium yangsharon-chromium merged commit e919590 into GoogleChrome:main Dec 3, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI is failing with clippy error

2 participants