Conversation
|
Could you explain why you changed so many of the tests to wait for
We could potentially just change the location of that file to be in |
Co-authored-by: Philip Walton <philipwalton@users.noreply.github.com>
Oh it appears I never hit send on a comment I wrote up for this!!! :-( So my thinking was Now I'm not 100% sure about how this works for Additionally, for most of these tests, basically the only thing waiting to Saying this, I still saw some flakiness with this change, which I can't explain so all of the above could be for naught, but it definitely seemed a bit more stable.
I did think about that, but wondered if there were some Windows people running this, that that would break. |
|
Closing this while we see how #603 fares.... |
Fixes #601
We already test suite twice, but frequently this fails due to flakiness.
This PR adds:
It doesn't solve the flakiness, but at least automates the reruns I'm doing manually anyway...