Initial commit: Add V-Start application files #2282

WafaeBakkali · 2025-08-25T20:28:42Z

Description

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Follow the CONTRIBUTING Guide.
You are listed as the author in your notebook or README file.
Your account is listed in CODEOWNERS for the file(s).
Ensure the tests and linter pass (Run nox -s format from the repository root to format).

Fixes #<issue_number_goes_here> 🦕

gemini-code-assist

Summary of Changes

Hello @WafaeBakkali, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a new application, V-Start, into the repository. The application is added as a Git submodule, which means its source code is maintained in a separate repository and referenced here. This approach facilitates modularity and independent management of the V-Start application's development lifecycle.

Highlights

New Application Integration: Introduces the V-Start application by adding it as a Git submodule under vision/sample-apps/.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces the V-Start sample application as a git submodule. While using submodules can be a valid approach for managing dependencies, adding it this way circumvents the code review process for the code contained within the submodule. The code at commit badea0b2ee79ff2a4164248c326c0463fe815317 has not been reviewed as part of this change, which poses a risk to the repository's quality and security. I've added a comment with suggestions on how to address this.

.github/CODEOWNERS

vision/sample-apps/V-Start/Dockerfile

holtskinner · 2025-08-26T15:30:49Z

vision/sample-apps/V-Start/README.md

+
+1.  **Clone the repository:**
+    ```bash
+    git clone https://github.com/WafaeBakkali/V-Start.git


Update this to the new repo link

vision/sample-apps/V-Start/README.md

holtskinner · 2025-08-26T15:32:15Z

vision/sample-apps/V-Start/README.md

+
+* [Node.js](https://nodejs.org/) (v18 or later recommended)
+* npm (usually comes with Node.js)
+* A Google Gemini API Key. You can get one from [Google AI Studio](https://aistudio.google.com/app/apikey).


Is there a reason you're using the Gemini Developer API instead of Vertex AI, since you're already using other Google Cloud Services?

Having two options is meant for flexibility. Many creative agencies that use Veo prefer a quick and simple setup for initial testing with an API Key, while other customers prefer the Vertex AI API

Right, I would agree that the API key is easier for setup, however you end up using Google Cloud Secret Manager and Cloud Run later, which ends up using Google Cloud anyway and requires the same IAM/gcloud auth setup. This could probably be simpler to use Vertex AI for Gemini as well and not need to store the API Key in secret manager.

vision/sample-apps/V-Start/src/features/enhancer.js

Co-authored-by: Holt Skinner <[email protected]>

… into V-Start

WafaeBakkali · 2025-08-26T17:43:23Z

@holtskinner Thanks for all the feedback. I've addressed all the requested changes

.github/CODEOWNERS

vision/sample-apps/V-Start/README.md

holtskinner · 2025-08-28T15:27:09Z

vision/sample-apps/V-Start/README.md

+
+* [Node.js](https://nodejs.org/) (v18 or later recommended)
+* npm (usually comes with Node.js)
+* A Google Gemini API Key. You can get one from [Google AI Studio](https://aistudio.google.com/app/apikey).


Right, I would agree that the API key is easier for setup, however you end up using Google Cloud Secret Manager and Cloud Run later, which ends up using Google Cloud anyway and requires the same IAM/gcloud auth setup. This could probably be simpler to use Vertex AI for Gemini as well and not need to store the API Key in secret manager.

Co-authored-by: Holt Skinner <[email protected]>

holtskinner · 2025-09-02T14:52:52Z

vision/sample-apps/V-Start/server.js

+
+    // Use a simple endpoint to validate the token
+    // We'll try to list models which is a read-only operation
+    const validationUrl = `https://us-central1-aiplatform.googleapis.com/v1/projects/${projectId}/locations/us-central1/models`;


It's recommended to use the JS Gen AI SDK rather than doing manual HTTP/REST Calls.

https://github.com/googleapis/js-genai

https://cloud.google.com/vertex-ai/generative-ai/docs/sdks/overview#googlegenaisdk_quickstart-nodejs_genai_sdk

Can you please convert this over to use the Gen AI SDK?

Done, and also updated GCloud Auth to be the default.

@WafaeBakkali Not sure this change went through. Looks like you're still using the raw REST calls here

… into V-Start

holtskinner · 2025-09-05T16:41:25Z

vision/sample-apps/V-Start/server.js

+const fetch = (...args) => import('node-fetch').then(({default: fetch}) => fetch(...args));
+
+// Import Google AI SDK (only for API key auth)
+const { GoogleGenerativeAI } = require('@google/generative-ai');


@WafaeBakkali This is the deprecated SDK, you should be using the new Gen AI SDK for all requests for the Gemini Developer API and Vertex AI

https://github.com/googleapis/js-genai

Be sure to change this throughout

Thanks for flagging this! I accidentally didn’t push the correct file, but that’s been fixed now. The project is fully using the new Gen AI SDK.

holtskinner · 2025-09-05T16:42:05Z

vision/sample-apps/V-Start/server.js

+
+    // Use a simple endpoint to validate the token
+    // We'll try to list models which is a read-only operation
+    const validationUrl = `https://us-central1-aiplatform.googleapis.com/v1/projects/${projectId}/locations/us-central1/models`;


@WafaeBakkali Not sure this change went through. Looks like you're still using the raw REST calls here

… into V-Start

WafaeBakkali requested a review from a team as a code owner August 25, 2025 20:28

gemini-code-assist bot reviewed Aug 25, 2025

View reviewed changes

Initial commit: Add V-Start application files

c267a18

WafaeBakkali force-pushed the V-Start branch from 4e80d65 to c267a18 Compare August 25, 2025 20:45

WafaeBakkali added 3 commits August 25, 2025 23:00

docs: Add words to spell check allow list

d355634

fix: Correct forbidden patterns

9709f27

fix: Correct GCP acronym in README

aa548bf

holtskinner requested changes Aug 26, 2025

View reviewed changes

holtskinner and others added 9 commits August 26, 2025 16:34

Merge branch 'main' into V-Start

a47a0e3

Update vision/sample-apps/V-Start/Dockerfile

201d0db

Co-authored-by: Holt Skinner <[email protected]>

Update vision/sample-apps/V-Start/README.md

bc240bb

Co-authored-by: Holt Skinner <[email protected]>

Update vision/sample-apps/V-Start/README.md

305559b

Co-authored-by: Holt Skinner <[email protected]>

Update vision/sample-apps/V-Start/README.md

098144c

Co-authored-by: Holt Skinner <[email protected]>

Update .github/CODEOWNERS

7338dce

Co-authored-by: Holt Skinner <[email protected]>

Update vision/sample-apps/V-Start/README.md

ee4234f

Co-authored-by: Holt Skinner <[email protected]>

fix: Address code review feedback by refactoring templates

15180ea

Merge branch 'V-Start' of https://github.com/WafaeBakkali/generative-ai…

67e84b2

… into V-Start

Merge branch 'main' into V-Start

b770f66

holtskinner requested changes Aug 28, 2025

View reviewed changes

WafaeBakkali and others added 3 commits August 29, 2025 01:54

Update .github/CODEOWNERS

50e6ee5

Co-authored-by: Holt Skinner <[email protected]>

Update vision/sample-apps/V-Start/README.md

e6387a7

Co-authored-by: Holt Skinner <[email protected]>

Merge branch 'main' into V-Start

17e8acf

holtskinner reviewed Sep 2, 2025

View reviewed changes

WafaeBakkali and others added 4 commits September 3, 2025 13:55

feat: Set gcloud auth as default, use GenAI SDK, and add UI spinners

212d1ea

Merge branch 'V-Start' of https://github.com/WafaeBakkali/generative-ai…

9d32f15

… into V-Start

style(server): Rename variable to resolve forbidden pattern lint error

42fefb7

Remove repo.png, replace with text

734b902

holtskinner approved these changes Sep 5, 2025

View reviewed changes

holtskinner requested changes Sep 5, 2025

View reviewed changes

WafaeBakkali added 6 commits September 6, 2025 04:15

Update genai sdk

908704b

Merge branch 'V-Start' of https://github.com/WafaeBakkali/generative-ai…

70a3573

… into V-Start

refactor: complete SDK migration and unify validation error messages

baeece2

refactor: clean up verbose logging

df5de3a

docs: fix duplicate setup instructions and LICENSE links in README

198a8ba

refactor: rename LICENCE to LICENSE for consistency

36cafc8

Initial commit: Add V-Start application files #2282

Are you sure you want to change the base?

Initial commit: Add V-Start application files #2282

Uh oh!

Conversation

WafaeBakkali commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

WafaeBakkali commented Aug 26, 2025

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

WafaeBakkali commented Aug 25, 2025 •

edited

Loading