Skip to content

eval: Added eval for troubleshooting and fixing OOMKilled pod#360

Merged
droot merged 3 commits into
GoogleCloudPlatform:mainfrom
prasad89:fix-oomkilled
Jun 19, 2025
Merged

eval: Added eval for troubleshooting and fixing OOMKilled pod#360
droot merged 3 commits into
GoogleCloudPlatform:mainfrom
prasad89:fix-oomkilled

Conversation

@prasad89
Copy link
Copy Markdown
Contributor

@prasad89 prasad89 commented Jun 18, 2025

This PR introduces a new evaluation task to test the assistant’s ability to diagnose and resolve pods crashing due to OOMKilled errors.

@prasad89
Copy link
Copy Markdown
Contributor Author

/cc @droot @noahlwest

Copy link
Copy Markdown
Collaborator

@noahlwest noahlwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just 1 comment here, the rest looks good to me.

Comment thread k8s-bench/tasks/fix-oomkilled/setup.sh Outdated
@prasad89 prasad89 requested a review from noahlwest June 18, 2025 17:53
Copy link
Copy Markdown
Member

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the eval. This is a good one.

Comment thread k8s-bench/tasks/fix-oomkilled/artifacts/memory-hungry-app.yaml
Comment thread k8s-bench/tasks/fix-oomkilled/setup.sh
Comment thread k8s-bench/tasks/fix-oomkilled/task.yaml
@prasad89 prasad89 requested a review from droot June 18, 2025 20:00
@droot
Copy link
Copy Markdown
Member

droot commented Jun 18, 2025

Once @noahlwest approves, we can get this in.

@droot
Copy link
Copy Markdown
Member

droot commented Jun 19, 2025

Once @noahlwest approves, we can get this in.

I see @noahlwest comment's are addressed, so will get this in.

@droot droot merged commit d541935 into GoogleCloudPlatform:main Jun 19, 2025
6 checks passed
@prasad89 prasad89 deleted the fix-oomkilled branch June 28, 2025 17:44
@droot
Copy link
Copy Markdown
Member

droot commented Oct 15, 2025

@prasad89 @noahlwest discovered a few issues with this eval #573 can you help us investigate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants