fix: vertexai dropping kubectl#450
Merged
Merged
Conversation
ShubyM
changed the title
droot
reviewed
Aug 1, 2025
| - ✅ Correct: `kubectl get pods --namespace=default` | ||
| - ❌ Incorrect: `kubectl --namespace=default get pods` | ||
| - This ensures commands are properly recognized and filtered by the system. | ||
|
|
Member
There was a problem hiding this comment.
This change moves this command structure guidelines block in the if EnableToolUseShim block and also in between the json formatting instructions. That means it will definitely affect the default tool calling (non-shim case).
Is it intentional ?
There was a problem hiding this comment.
Pull Request Overview
This PR addresses issue #447 by fixing a problem where vertexai was dropping the kubectl prefix from generated commands. The change modifies the system prompt template to provide clearer and more explicit guidance about proper kubectl command formatting.
Key changes:
- Added explicit examples showing correct vs incorrect kubectl command formats
- Reinforced the requirement that all kubectl commands must include the
kubectlprefix - Added a reminder in the guidelines section about proper kubectl command structure
Comments suppressed due to low confidence (1)
droot
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modifies system prompt to fix #447. If anyone has better ways of evaluating if this works 100 percent of the time please let me know!