feat: meta query tests#506
Merged
Merged
Conversation
droot
reviewed
Aug 25, 2025
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| a := tt.expectations(t) | ||
| ans, handled, err := a.handleMetaQuery(ctx, tt.query) |
Member
There was a problem hiding this comment.
I remember discussing if we can bring the test driver to closer to how UIs interact with agent. Are we planning to do that ?
Collaborator
Author
There was a problem hiding this comment.
I was planning on making a separate PR for driving the agent in the same way the UI does. I wanted to isolate this PR to introduce mocking and unit testing the handleMetaQuery function
droot
approved these changes
Aug 26, 2025
| generate: | ||
| go generate ./internal/mocks | ||
|
|
||
| verify-mocks: |
Member
There was a problem hiding this comment.
we should add CI Job like we have for other operations in a follow up. Ask gemini to do it :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces mocks auto generated by gomock and unit testing of handleMetaQuery