feat: Fix and refactor setup-dev-cluster verification script#522
Merged
Conversation
droot
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that this eval would consistently fail when checking for quotas, despite things being set up correctly. This was caused by a small error in the check syntax. This verify script is kind of big, so I also tried to refactor it into something more readable and easy to debug.
mainfunction orchestrating the checks.cleanupfunction that runs on exit to ensure all created test resources are removed, even if the script fails.--quietflag for cleaner output instead of sending to /dev/nullset -euo pipefailfor more predictable behavior on errors.A successful run looks like this: