Skip to content

refactor(transports): remove SSE server mode #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
droot merged 2 commits into from
Oct 23, 2025
Merged

refactor(transports): remove SSE server mode #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fa52d2
refactor: remove SSE server mode and update supported modes documenta…
appleboy Oct 4, 2025
315a1a2
Merge branch 'main' into sse
appleboy Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cmd/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ type Options struct {
MaxIterations int `json:"maxIterations,omitempty"`
// MCPServerMode is the mode of the MCP server. only works with --mcp-server.
MCPServerMode string `json:"mcpServerMode,omitempty"`
// Set the HTTP endpoint port for the MCP server when using HTTP transports like SSE or streamable-http.
// Set the HTTP endpoint port for the MCP server when using HTTP transports like streamable-http.
HTTPPort int `json:"httpPort,omitempty"`
// KubeConfigPath is the path to the kubeconfig file.
// If not provided, the default kubeconfig path will be used.
Expand Down Expand Up @@ -166,8 +166,8 @@ func (o *Options) InitDefaults() {
// Default to not skipping SSL verification
o.SkipVerifySSL = false
// Default MCP server mode is stdio
o.MCPServerMode = "stdio" // Default port for HTTP endpoint when using SSE or streamable-http modes
// Default port for HTTP endpoint when using SSE or streamable-http modes
o.MCPServerMode = "stdio"
// Default port for HTTP endpoint when using streamable-http mode
o.HTTPPort = 9080

// Session management options
Expand Down Expand Up @@ -307,8 +307,8 @@ func (opt *Options) bindCLIFlags(f *pflag.FlagSet) error {
f.BoolVar(&opt.ExternalTools, "external-tools", opt.ExternalTools, "in MCP server mode, discover and expose external MCP tools")
f.StringArrayVar(&opt.ToolConfigPaths, "custom-tools-config", opt.ToolConfigPaths, "path to custom tools config file or directory")
f.BoolVar(&opt.MCPClient, "mcp-client", opt.MCPClient, "enable MCP client mode to connect to external MCP servers")
f.StringVar(&opt.MCPServerMode, "mcp-server-mode", opt.MCPServerMode, "mode of the MCP server. Supported values: stdio, sse, streamable-http")
f.IntVar(&opt.HTTPPort, "http-port", opt.HTTPPort, "port for the HTTP endpoint in MCP server mode (used with --mcp-server when --mcp-server-mode is sse or streamable-http)")
f.StringVar(&opt.MCPServerMode, "mcp-server-mode", opt.MCPServerMode, "mode of the MCP server. Supported values: stdio, streamable-http")
f.IntVar(&opt.HTTPPort, "http-port", opt.HTTPPort, "port for the HTTP endpoint in MCP server mode (used with --mcp-server when --mcp-server-mode is streamable-http)")
f.BoolVar(&opt.EnableToolUseShim, "enable-tool-use-shim", opt.EnableToolUseShim, "enable tool use shim")
f.BoolVar(&opt.Quiet, "quiet", opt.Quiet, "run in non-interactive mode, requires a query to be provided as a positional argument")

Expand Down
9 changes: 1 addition & 8 deletions cmd/mcp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ type kubectlMCPServer struct {
tools tools.Tools
workDir string
mcpManager *mcp.Manager // Add MCP manager for external tool calls
mcpServerMode string // Server mode (e.g., "streamable-http", "sse")
mcpServerMode string // Server mode (e.g., "streamable-http", "stdio")
httpPort int // Port for HTTP-based server modes
}

Expand Down Expand Up @@ -164,13 +164,6 @@ func (s *kubectlMCPServer) Serve(ctx context.Context) error {
klog.Info("Starting kubectl-ai MCP server")

switch s.mcpServerMode {
case "sse":
// Start the server in SSE mode
klog.Infof("Starting MCP server in SSE mode on port %d", s.httpPort)
sseServer := server.NewSSEServer(s.server)
endpoint := fmt.Sprintf(":%d", s.httpPort)
klog.Infof("Listening for SSE connections on port %d", s.httpPort)
return sseServer.Start(endpoint)
case "streamable-http":
// Start the server in streamable HTTP mode
klog.Infof("Starting MCP server in streamable HTTP mode on port %d", s.httpPort)
Expand Down
6 changes: 3 additions & 3 deletions docs/mcp-server.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Run the server with the streamable HTTP transport to serve compatible MCP client
kubectl-ai --mcp-server --mcp-server-mode streamable-http --http-port 9080
```

This listens on `http://localhost:9080/mcp` by default. Use `--mcp-server-mode sse` for legacy HTTP+SSE clients.
This listens on `http://localhost:9080/mcp` by default.

## Configuration

Expand Down Expand Up @@ -133,8 +133,8 @@ Additional tools are available depending on the configured MCP servers:
| `--mcp-server` | `false` | Run in MCP server mode |
| `--external-tools` | `false` | Discover and expose external MCP tools (requires --mcp-server) |
| `--kubeconfig` | `~/.kube/config` | Path to kubeconfig file |
| `--mcp-server-mode` | `stdio` | Transport for the MCP server (`stdio`, `sse`, or `streamable-http`) |
| `--http-port` | `9080` | Port for the HTTP endpoint when using `sse` or `streamable-http` modes |
| `--mcp-server-mode` | `stdio` | Transport for the MCP server (`stdio` or `streamable-http`) |
| `--http-port` | `9080` | Port for the HTTP endpoint when using `streamable-http` modes |

## Architecture

Expand Down
Loading