evals: Add per-task timeout to k8s-bench#566
Merged
Merged
Conversation
noahlwest
changed the title
droot
reviewed
Oct 7, 2025
|
|
||
| // Run the agent | ||
| agentOutput, err := x.runAgent(ctx) | ||
| agentOutput, err := x.runAgent(taskCtx) |
Member
There was a problem hiding this comment.
I am wondering reusing the same ctx is a good idea ? will this stack up the timeouts ? or will the overall setup/run will have a deadline of 5 mins or individually 5 min. deadline ?
Collaborator
Author
There was a problem hiding this comment.
This should have a deadline of 5 minutes total per eval (create-canary gets 5m, fix-image-pull gets 5m, etc.) and the 5 minute limit is for the setup, run, and cleanup. We could up it to 10 to be safer since it includes the setup, run, and cleanup.
droot
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds default 5 minute timeout to any task. Per-task timeout can also be set in the task.yaml