fix: process all candidates from LLM response (#421)#650
Open
gkhandale-aziro wants to merge 1 commit into
Open
fix: process all candidates from LLM response (#421)#650gkhandale-aziro wants to merge 1 commit into
gkhandale-aziro wants to merge 1 commit into
Conversation
OpenAI reasoning models (o1, o3, o4-mini) use the Responses API which returns tool calls and text as separate candidates in a single response. The conversation loop only processed candidates[0], silently dropping tool calls that appeared in subsequent candidates. Fix: iterate over all candidates instead of just the first one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenAI reasoning models (o1, o3, o4-mini) use the Responses API which returns tool calls and text as separate candidates in a single response. The conversation loop only processed candidates[0], silently dropping tool calls that appeared in subsequent candidates.
Fix: iterate over all candidates instead of just the first one.