Skip to content

Added skip_files to prevent errors on deploy #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added skip_files to prevent errors on deploy #528

wants to merge 1 commit into from

Conversation

johnpyp
Copy link

@johnpyp johnpyp commented Dec 4, 2017

In my tutorial run, there was an error during deploying the Hello World app. It said you can't have a yarn.lock and package.lock file when deploying, and to add skip_files to ignore one of them.

In my tutorial run, there was an error during deploying the Hello World app. It said you can't have a yarn.lock and package.lock file when deploying, and to add skip_files to ignore one of them.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@johnpyp
Copy link
Author

johnpyp commented Dec 4, 2017

I signed agreement

@googlebot
Copy link

CLAs look good, thanks!

@jmdobry
Copy link
Member

jmdobry commented Dec 8, 2017

Thanks for pointing this out. However, our sample currently doesn't have either a package-lock.json or a yarn.lock file, and I don't really want favor one package manager over the other, or mess with Yarn users who may be trying to deploy this sample. My recommendation is to only use one package manager and to delete the lock files from other managers.

@jmdobry jmdobry closed this Dec 8, 2017
ace-n pushed a commit that referenced this pull request Nov 16, 2022
* samples: updates face and person to v1

* 🦉 Updates from OwlBot

* fix: docs link issues

* fix: appeasethe doc checker

* fix: revert READMEs

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this pull request Nov 17, 2022
* samples: updates face and person to v1

* 🦉 Updates from OwlBot

* fix: docs link issues

* fix: appeasethe doc checker

* fix: revert READMEs

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ahrarmonsur pushed a commit that referenced this pull request Nov 17, 2022
* samples: updates face and person to v1

* 🦉 Updates from OwlBot

* fix: docs link issues

* fix: appeasethe doc checker

* fix: revert READMEs

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants