Skip to content

Conversation

@vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Sep 4, 2022

Addresses: #1682
(couldn't test in local, since feature not enabled in my gcp proj)

Design doc: go/php-storage-autoclass
PR for python: googleapis/python-storage#791

@snippet-bot
Copy link

snippet-bot bot commented Sep 4, 2022

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Sep 4, 2022
@vishwarajanand vishwarajanand added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Sep 4, 2022
@product-auto-label product-auto-label bot added api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples. labels Sep 4, 2022
@vishwarajanand vishwarajanand removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 14, 2022
@vishwarajanand vishwarajanand marked this pull request as ready for review September 14, 2022 09:16
@vishwarajanand vishwarajanand requested a review from a team as a code owner September 14, 2022 09:16
@saranshdhingra saranshdhingra self-assigned this Sep 14, 2022
@vishwarajanand vishwarajanand added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 21, 2022
@vishwarajanand vishwarajanand enabled auto-merge (squash) October 21, 2022 07:32
@vishwarajanand
Copy link
Contributor Author

Update: To be merged in the first week of Nov.

@vishwarajanand vishwarajanand removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 21, 2022
Copy link

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on the samples. Deferring to @saranshdhingra for further review

@vishwarajanand vishwarajanand merged commit 81498af into GoogleCloudPlatform:master Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants