Skip to content

Add Managed Kafka Connect cluster code samples #13515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

salmany
Copy link

@salmany salmany commented Jul 24, 2025

Description

  • Adds sample code for creating, deleting, getting, listing and updating Managed Kafka Connect clusters

Fixes https://b.corp.google.com/issues/430087669

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

salmany added 2 commits July 24, 2025 00:36
clusters

* Adds code examples for creating, deleting,
getting, listing and updating Managed Kafka
Connect clusters
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 24, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @salmany, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the sample code coverage for Google Cloud's Managed Kafka Connect service. It provides developers with practical, runnable examples for managing Connect clusters programmatically, which will greatly aid in adoption and understanding of the service. The changes include new sample files for various CRUD operations and their corresponding tests, along with a minor dependency update.

Highlights

  • New Managed Kafka Connect Samples: This PR introduces a comprehensive set of Python code samples for interacting with Managed Kafka Connect clusters, covering common operations like creation, retrieval, listing, updating, and deletion.
  • Dedicated Test Suite: A new test file (clusters_test.py) has been added to provide robust unit tests for all the newly introduced Managed Kafka Connect cluster operations, ensuring their correctness and functionality.
  • Dependency Update: The google-cloud-managedkafka library dependency has been updated from version 0.1.5 to 0.1.12 in requirements.txt to align with the latest API capabilities and fixes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new code samples for managing Kafka Connect clusters. The changes are well-implemented and cover a good range of functionalities.

My review focuses on improving the robustness and maintainability of the new samples. Key suggestions include:

  • Replacing the deprecated .message attribute on exceptions with str(e).
  • Adding timeouts to long-running operations to prevent scripts from hanging.
  • Incorporating error handling for API calls to manage potential failures gracefully.
  • A minor change for code clarity in a TODO comment.

These adjustments will make the samples more reliable and easier for developers to use.

salmany and others added 7 commits July 23, 2025 20:50
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@salmany salmany marked this pull request as ready for review July 24, 2025 14:34
@salmany salmany requested review from a team as code owners July 24, 2025 14:34
Copy link

snippet-bot bot commented Jul 24, 2025

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant