Skip to content

chore(deps): update dependency django to v5.2.6 #13565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency django to v5.2.6 #13565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion appengine/flexible/django_cloudsql/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Django==5.2.5
Django==5.2.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This Django version is incompatible with the Python versions configured for this sample. The app.yaml specifies Python 3.7, and the noxfile_config.py indicates testing on Python 3.9. Django 5.x requires Python 3.10+. This will cause deployment and tests to fail. To support multiple Python versions, you should use conditional dependencies to specify a compatible Django version for each Python range.

gunicorn==23.0.0
psycopg2-binary==2.9.10
django-environ==0.12.0
Expand Down
2 changes: 1 addition & 1 deletion appengine/flexible/hello_world_django/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Django==5.2.5
Django==5.2.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This Django version is incompatible with some of the Python versions used for testing this sample. The noxfile_config.py indicates testing on Python 3.8 and 3.9, but Django 5.x requires Python 3.10+. This will cause tests on those Python versions to fail. To support multiple Python versions, you should use conditional dependencies to specify a compatible Django version for each Python range (e.g., Django 4.2.x for Python < 3.10).

gunicorn==23.0.0
2 changes: 1 addition & 1 deletion appengine/flexible_python37_and_earlier/django_cloudsql/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Django==5.2.5
Django==5.2.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This sample is configured for Python 3.7 (as specified in app.yaml and noxfile_config.py), but Django 5.x requires Python 3.10 or newer. This Django version is incompatible and will cause deployment and tests to fail. The version should be downgraded to one that supports Python 3.7, for example, the Django 3.2 LTS series.

Django~=3.2.0

gunicorn==23.0.0
psycopg2-binary==2.9.10
django-environ==0.12.0
Expand Down
2 changes: 1 addition & 1 deletion appengine/flexible_python37_and_earlier/hello_world_django/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
Django==5.2.5
Django==5.2.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This sample is configured for Python 3.7 (as specified in noxfile_config.py), but Django 5.x requires Python 3.10 or newer. This Django version is incompatible and will cause tests to fail. The version should be downgraded to one that supports Python 3.7, for example, the Django 3.2 LTS series.

Django~=3.2.0

gunicorn==23.0.0
4 changes: 2 additions & 2 deletions kubernetes_engine/django_tutorial/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Django==5.2.5; python_version >= "3.10"
Django==4.2.23; python_version >= "3.8" and python_version < "3.10"
Django==5.2.6; python_version >= "3.10"
Django==5.2.6; python_version >= "3.8" and python_version < "3.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update is incorrect. Django version 5.2.6 requires Python 3.10 or newer, but this line applies it to Python versions 3.8 and 3.9. This will cause a dependency installation failure on those Python versions. The Django version for this Python range should remain on the 4.2.x series.

Django==4.2.23; python_version >= "3.8" and python_version < "3.10"

# Uncomment the mysqlclient requirement if you are using MySQL rather than
# PostgreSQL. You must also have a MySQL client installed in that case.
#mysqlclient==1.4.1
Expand Down
4 changes: 2 additions & 2 deletions run/django/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
Django==5.2.5; python_version >= "3.10"
Django==4.2.23; python_version >= "3.8" and python_version < "3.10"
Django==5.2.6; python_version >= "3.10"
Django==5.2.6; python_version >= "3.8" and python_version < "3.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This update is incorrect. Django version 5.2.6 requires Python 3.10 or newer, but this line applies it to Python versions 3.8 and 3.9. This will cause a dependency installation failure on those Python versions. The Django version for this Python range should remain on the 4.2.x series.

Django==4.2.23; python_version >= "3.8" and python_version < "3.10"

django-storages[google]==1.14.6
django-environ==0.12.0
psycopg2-binary==2.9.10
Expand Down