Skip to content

Fix test for slack slash using knowledge graph API #1613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 7, 2018
Merged

Fix test for slack slash using knowledge graph API #1613

merged 6 commits into from
Dec 7, 2018

Conversation

@yukuairoy
Copy link
Contributor

@yukuairoy yukuairoy commented Aug 5, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2018
@ace-n
Copy link

ace-n commented Nov 22, 2018 •
edited
Loading

LGTM when tests pass. (We'll need to add a config.json file to the test, though.)

@yukuairoy
Copy link
Contributor Author

yukuairoy commented Nov 30, 2018

Can this PR be merged?

@engelke engelke merged commit f241636 into GoogleCloudPlatform:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ace-n ace-n ace-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yukuairoy @ace-n @engelke @googlebot