Skip to content

Simplify opencensus quickstart tests. #2990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Simplify opencensus quickstart tests. #2990

merged 4 commits into from
Feb 26, 2020

Conversation

kurtisvg
Copy link
Contributor

Slim down the opencensus tests to only check that the snippet runs successfully, and avoid testing the library / api.

Fixes #2903

@kurtisvg kurtisvg requested a review from leahecole February 26, 2020 00:18
@kurtisvg kurtisvg requested a review from a team as a code owner February 26, 2020 00:18
@kurtisvg kurtisvg self-assigned this Feb 26, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 26, 2020
from opencensus.stats import measure
from opencensus.stats import stats
from opencensus.stats import view
from. import metrics_quickstart
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should just be import metrics_quickstart

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Feb 26, 2020
@leahecole leahecole merged commit ff9682e into master Feb 26, 2020
@leahecole leahecole deleted the opencencus-test-fix branch February 26, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opencensus.metrics_quickstart_test.TestMetricsQuickstart: test_measurement_map_record failed
4 participants