Skip to content

[jobs] testing: use multiple projects #4068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions jobs/v4beta1/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
To run the sample, you need to enable the API at: https://console.cloud.google.com/apis/library/jobs.googleapis.com

To run the sample, you need to have the following roles:

* `Talent Solution Job Editor`
* `Talent Solution Profile Editor`
19 changes: 18 additions & 1 deletion jobs/v4beta1/job_search_list_tenants_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,30 @@
# limitations under the License.

import os
import uuid

from google.cloud import talent
import pytest

import job_search_list_tenants

PROJECT_ID = os.environ["GOOGLE_CLOUD_PROJECT"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this env var is commented out in the noxfile_config.py, Does it get assigned from somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not commenting out :)

Long story, but we're copying noxfile-template.py at the project root directory to noxfile.py, and use it for driving the test.

noxfile.py will override the values set by the build config files (e.g. py-3.6 config)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see



def test_list_tenants(capsys):
@pytest.fixture(scope="module")
def test_tenant():
client = talent.TenantServiceClient()
external_id = f'test_tenant_{uuid.uuid4().hex}'
parent = client.project_path(PROJECT_ID)
tenant = {"external_id": external_id}
resp = client.create_tenant(parent, tenant)

yield resp

client.delete_tenant(resp.name)


def test_list_tenants(capsys, test_tenant):
job_search_list_tenants.list_tenants(PROJECT_ID)
out, _ = capsys.readouterr()
assert "Tenant Name:" in out
37 changes: 37 additions & 0 deletions jobs/v4beta1/noxfile_config.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# Copyright 2020 Google LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# Default TEST_CONFIG_OVERRIDE for python repos.

# You can copy this file into your directory, then it will be inported from
# the noxfile.py.

# The source of truth:
# https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/noxfile_config.py

TEST_CONFIG_OVERRIDE = {
# You can opt out from the test for specific Python versions.
'ignored_versions': ["2.7"],

# An envvar key for determining the project id to use. Change it
# to 'BUILD_SPECIFIC_GCLOUD_PROJECT' if you want to opt in using a
# build specific Cloud project. You can also use your own string
# to use your own Cloud project.
# 'gcloud_project_env': 'GOOGLE_CLOUD_PROJECT',
'gcloud_project_env': 'BUILD_SPECIFIC_GCLOUD_PROJECT',

# A dictionary you want to inject into your test. Don't put any
# secrets here. These values will override predefined values.
'envs': {},
}