Skip to content

Conversation

@odedfos
Copy link
Contributor

@odedfos odedfos commented Jul 3, 2020

Description

Fixes #4237

Note: It's a good idea to open an issue first for discussion.

Checklist

@odedfos odedfos requested a review from a team as a code owner July 3, 2020 15:23
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 3, 2020
@odedfos
Copy link
Contributor Author

odedfos commented Jul 3, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 3, 2020
@odedfos odedfos changed the title #4237 Filter cpu query to get the metrics for the correct resources #4237 BT metricscaler - Filter cpu query to get the metrics for the correct resources Jul 5, 2020
@leahecole leahecole requested review from billyjacobson and kolea2 July 6, 2020 20:59
@leahecole
Copy link
Collaborator

@GoogleCloudPlatform/bigtable-dpe for review

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 11, 2020
@leahecole
Copy link
Collaborator

Hey @odedfos - it looks like our CI/CD is failing with this error:

Traceback (most recent call last):
  File "/workspace/bigtable/metricscaler/metricscaler_test.py", line 45, in test_get_cpu_load
    assert float(get_cpu_load(BIGTABLE_INSTANCE, BIGTABLE_INSTANCE)) > 0.0
  File "/workspace/bigtable/metricscaler/metricscaler.py", line 49, in get_cpu_load
    cpu = next(cpu_query.iter())
StopIteration

Could you take a look and see how to resolve it?

…to get the metrics for the correct resources
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2020
@odedfos
Copy link
Contributor Author

odedfos commented Jul 12, 2020

I've fixed the failing tests

@leahecole leahecole added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@leahecole
Copy link
Collaborator

Hi @odedfos - sorry for delay. CI is passing, but lint is failing - I'll fix those lint errors for you and get this merged asap. Sorry for the delay! Thanks @billyjacobson for the review :)

@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 16, 2020
@leahecole
Copy link
Collaborator

This 3.7 failure seems like a fluke - I'm rerunning to see what happens

@leahecole leahecole merged commit 238722a into GoogleCloudPlatform:master Jul 16, 2020
@odedfos
Copy link
Contributor Author

odedfos commented Jul 17, 2020

Thanks @leahecole for helping to get this in!

busunkim96 pushed a commit to googleapis/python-bigtable that referenced this pull request Jul 31, 2020
…orrect resources [(#4238)](GoogleCloudPlatform/python-docs-samples#4238)

* #4237 Added a filter to the cpu & storage queries to get the metrics for the correct resources

* fix lint

* fix lint again

Co-authored-by: Leah E. Cole <[email protected]>
Co-authored-by: Leah Cole <[email protected]>
busunkim96 added a commit to googleapis/python-bigtable that referenced this pull request Aug 4, 2020
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Nov 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bigtable: metricscaler inspects the wrong cluster

5 participants