Skip to content

chore(deps): update dependency google-cloud-logging to v3.2.2 #8167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jul 12, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
google-cloud-logging ==3.1.2 -> ==3.2.5 age adoption passing confidence
google-cloud-logging ==2.7.2 -> ==3.2.5 age adoption passing confidence

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from a team as code owners July 12, 2022 14:44
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 12, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 12, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2022
@ace-n
Copy link

ace-n commented Jul 14, 2022

It looks like this is the offending PR. (It adds an extra logging statement, which breaks our tests.)

@daniel-sanche which option is better here?

  1. Update these samples to pass with this change
  2. Add a flag to the library to disable this behavior

I have a slight preference for the second option, but I definitely don't have enough context to know for sure.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 15, 2022
@engelke engelke added the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 15, 2022
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 16, 2022
@engelke engelke assigned daniel-sanche and unassigned engelke Aug 16, 2022
@renovate-bot renovate-bot changed the title chore(deps): update dependency google-cloud-logging to v3.2.0 chore(deps): update dependency google-cloud-logging to v3.2.2 Aug 30, 2022
@renovate-bot renovate-bot force-pushed the renovate/google-cloud-logging-3.x branch from c3c4925 to 9a75d26 Compare August 30, 2022 19:28
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 30, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 23, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2022
@dandhlee
Copy link
Collaborator

@daniel-sanche friendly ping!

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2022
@daniel-sanche
Copy link
Member

daniel-sanche commented Nov 14, 2022

Sorry, must have missed this!

The easiest solution for testing is probably to use the existing internal flag to disable instrumentation for the tests here: google.cloud.logging_v2._instrumentation_emitted = True. I think changing the tests is also acceptable if that ends up being easier though.

Let me know if you want me to take on the changes

@dandhlee
Copy link
Collaborator

Thanks Daniel! I'll leave this open for now, and open a separate issue and assign it to you @ace-n but feel free to assign to someone else who has bandwidth if you can't work on it soon.

@dandhlee dandhlee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 15, 2022
@dandhlee
Copy link
Collaborator

For anyone else who needs higher version of cloud logging, please make the updates separately.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@engelke engelke added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@engelke engelke assigned engelke and unassigned daniel-sanche Nov 16, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2022
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 16, 2022
@engelke
Copy link
Contributor

engelke commented Nov 16, 2022

Rolled back logging version for Cloud Functions sample, will figure out problem and fix in a future PR.

@engelke engelke removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 16, 2022
@engelke engelke merged commit df15566 into GoogleCloudPlatform:main Nov 16, 2022
@engelke
Copy link
Contributor

engelke commented Nov 17, 2022

Why would this only affect the Cloud Functions v2 test? And why only when run by Kokoro? The tests pass locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants