-
Notifications
You must be signed in to change notification settings - Fork 6.5k
chore(deps): update dependency google-cloud-logging to v3.2.2 #8167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency google-cloud-logging to v3.2.2 #8167
Conversation
It looks like this is the offending PR. (It adds an extra logging statement, which breaks our tests.) @daniel-sanche which option is better here?
I have a slight preference for the second option, but I definitely don't have enough context to know for sure. |
c3c4925
to
9a75d26
Compare
@daniel-sanche friendly ping! |
Sorry, must have missed this! The easiest solution for testing is probably to use the existing internal flag to disable instrumentation for the tests here: Let me know if you want me to take on the changes |
Thanks Daniel! I'll leave this open for now, and open a separate issue and assign it to you @ace-n but feel free to assign to someone else who has bandwidth if you can't work on it soon. |
For anyone else who needs higher version of cloud logging, please make the updates separately. |
Rolled back logging version for Cloud Functions sample, will figure out problem and fix in a future PR. |
Why would this only affect the Cloud Functions v2 test? And why only when run by Kokoro? The tests pass locally. |
This PR contains the following updates:
==3.1.2
->==3.2.5
==2.7.2
->==3.2.5
⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.