This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Changed CLI to use --types flag, a comma separated list of desired an… #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-prindle
force-pushed
the
type-list
branch
4 times, most recently
from
006437d to
b7f283b
Compare
nkubala
suggested changes
Sep 1, 2017
aaron-prindle
force-pushed
the
type-list
branch
2 times, most recently
from
be604f0 to
3de426f
Compare
|
tests and README updated. updating |
aaron-prindle
force-pushed
the
type-list
branch
7 times, most recently
from
6a11153 to
256efba
Compare
|
Looks like we accidentally added a "main" file to the repo that's now conflicting. You'll have to delete. |
aaron-prindle
force-pushed
the
type-list
branch
from
256efba to
1c91683
Compare
|
deleted 'main' |
dlorenc
approved these changes
Sep 6, 2017
cmd/diff_test.go
Outdated
| @@ -13,7 +13,8 @@ var diffArgNumTests = []testpair{ | |||
|
|
|||
| func TestDiffArgNum(t *testing.T) { | |||
| for _, test := range diffArgNumTests { | |||
| valid, err := checkDiffArgNum(test.input) | |||
| err := checkDiffArgNum(test.input) | |||
There was a problem hiding this comment.
This is a bit weird of a construct. Do we need err and valid? Could you do something like:
valid := (checkDiffArgNum == nil) ?
There was a problem hiding this comment.
good point, changed
aaron-prindle
force-pushed
the
type-list
branch
from
1c91683 to
b2b5473
Compare
|
the tests output the err on unexpected errors so storing it separately is needed. changing it back |
|
i can just use (err == nil) in place of valid |
aaron-prindle
force-pushed
the
type-list
branch
from
b2b5473 to
49e498b
Compare
aaron-prindle
force-pushed
the
type-list
branch
from
49e498b to
c8a7267
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.