Skip to content

Replace legacy artboards with artboard nodes #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #144
Keavon opened this issue Apr 26, 2023 · 1 comment
Closed
Tracked by #144

Replace legacy artboards with artboard nodes #1171

Keavon opened this issue Apr 26, 2023 · 1 comment
Assignees
Labels
Graphene Involves the node graph system/engine used by Graphite
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented Apr 26, 2023

This is an example in our mockup of how artboards will work, with an Artboard node feeding into a layer, and the layer's vertical output being given to the graph's output:

image

- [x] #1205 - Add an Artboard node which takes `GraphicElement` input and produces `Artboard` or `ArtboardGroup` output data.
- [x] #1224 - These node-based artboards will need to live in a new node graph attached directly to the document itself, rather than being part of any one layer. This special node graph will become the singular node graph representing a whole document once the transition away from legacy layers is complete.
- [x] #1221 - The output from that special node graph is of type `ArtboardGroup` and it should enter the SVG output renderer and become an appropriately colored background rectangle as well as a definition for a [clipping mask](https://developer.mozilla.org/en-US/docs/Web/SVG/Tutorial/Clipping_and_masking). (A checkered transparency background (defined in CSS) should also be included in the viewport, but in a way that causes it to be excluded from things that rasterize the artboard.)
- [x] #1222 - The Artboard tool will also need to be updated to work with node-based artboards, plus any editor features like the New Document dialog and *Document* > *Clear Artboards*.
- [x] #1223 - Legacy artboard code can be removed.
@Keavon
Copy link
Member Author

Keavon commented Aug 26, 2023

Closed by 595f546

@Keavon Keavon closed this as completed Aug 26, 2023
@github-project-automation github-project-automation bot moved this from In-Progress to Completed This Sprint in Task Board Aug 26, 2023
@Keavon Keavon added this to the Sprint 29 milestone Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphene Involves the node graph system/engine used by Graphite
Projects
Archived in project
Development

No branches or pull requests

2 participants