Skip to content

Select Tool: Viewport layer click selection #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Keavon opened this issue May 23, 2021 · 3 comments · Fixed by #178
Closed

Select Tool: Viewport layer click selection #140

Keavon opened this issue May 23, 2021 · 3 comments · Fixed by #178
Assignees
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented May 23, 2021

Click a layer in the viewport to select it. We'll probably want to add a data- attribute to each SVG element to identify its path and just use addEventHandler to handle the click event. Depends on #137.

This pertains to the Select Tool.
Select Tool

Complexity: 1
Involves: Frontend (JS)

@Keavon Keavon added this to the Sprint 4 (current) milestone May 23, 2021
@Keavon Keavon added the Blocked label May 26, 2021
@Keavon Keavon added Available Web Involves web programming (TypeScript, Svelte, CSS) and removed Blocked labels Jun 10, 2021
@pkupper pkupper self-assigned this Jun 10, 2021
@Keavon Keavon added Rust and removed Web Involves web programming (TypeScript, Svelte, CSS) labels Jun 13, 2021
@Keavon Keavon added the Blocked label Jun 17, 2021
@Keavon
Copy link
Member Author

Keavon commented Jun 17, 2021

Blocked presently on #100.

@Keavon Keavon removed the Blocked label Jul 3, 2021
@Keavon
Copy link
Member Author

Keavon commented Jul 3, 2021

@pkupper I believe this is unblocked now that #100 is closed from merging #175. Is there anything else I might be forgetting about that's a blocker? (If so, I can re-add the Blocked label.) Do you think it would be feasible to get this finished up and merged by either this weekend (in time for the Rust Gamedev newsletter) or the coming week (in time for the end of the sprint and the Rust Gamedev Meetup live demo)? I would be really excited to show off your great work with this (and, if possible, #143 and #207, even if this can just be completed to un-soft-block those for someone else to take on this sprint) in a week to the folks watching the Rust Gamedev Meetup if it works within your schedule over the coming week.

@pkupper
Copy link
Contributor

pkupper commented Jul 3, 2021

#175 is mostly done. I rebased on the canvas transform changes last weekend. There are only two minor open issues where deselecting when clicking empty space does not work and the tolerance when selecting lines depends on the length of the line. I will definitely be able to fix those up this weekend, although most likely tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants