Skip to content

Select Tool: Grab/drag selected layers around viewport #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Keavon opened this issue May 23, 2021 · 6 comments · Fixed by #293
Closed

Select Tool: Grab/drag selected layers around viewport #143

Keavon opened this issue May 23, 2021 · 6 comments · Fixed by #293
Assignees
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented May 23, 2021

If the user has no layers selected, this will select the layer under the cursor (see #140) and then drag (transform) it. If multiple are selected, and the drag occurs on one of the selected, it will drag (transform) all of them. If one or more are selected but the drag occurs on another layer, it deselects the current selection and selects the new layer and drags it (like in the first sentence).

After this is implemented, we can then add support for snapping: #200.

Complexity: 3
Involves: Editor (Rust), Document (Rust)

@Keavon Keavon added this to the Sprint 4 (current) milestone May 23, 2021
@Keavon Keavon added Available Web Involves web programming (TypeScript, Svelte, CSS) and removed Blocked labels Jun 10, 2021
@Keavon Keavon added the P-High label Jun 13, 2021
@Keavon Keavon changed the title Select Tool: Grab/drag selection around viewport Select Tool: Grab/drag selected layers around viewport Jun 13, 2021
@Keavon Keavon removed the Web Involves web programming (TypeScript, Svelte, CSS) label Jun 17, 2021
@Keavon
Copy link
Member Author

Keavon commented Jul 3, 2021

@pkupper do you know if this task is blocked, or soft-blocked in some capacity, by your work on #178? Or could somebody get to work on this right now? It does require knowledge of where the user clicks because dragging should only happen if the mousedown occurred on the shapes that will be dragged.

@pkupper
Copy link
Contributor

pkupper commented Jul 3, 2021

This is does require #178. I'll see how much work this is and perhaps include it in my PR. We haven't really had the need to modify existing Layer yet so it will require some new Document Operations

@Keavon Keavon modified the milestones: Sprint 5, Sprint 6 (current) Jul 10, 2021
@Keavon Keavon added Blocked and removed Available labels Jul 10, 2021
@Keavon
Copy link
Member Author

Keavon commented Jul 10, 2021

Blocked on #243.

@Keavon
Copy link
Member Author

Keavon commented Jul 13, 2021

@AyeTbk you might like this one.

Edit: I actually just remembered you expressed interest in bounding boxes rather than this one, if my memory serves me correctly (I got them mixed up since they're similar). We realized #151 is not actually blocked, and its completion will open up #207 which I believe you were interested in. Would you want to work on those two?

Meanwhile this issue (#143) relates to nudging, which @henryksloan already completed, so perhaps this would be a logical one for him to do next.

@henryksloan
Copy link
Contributor

I'd like to take this one, now that Fill is merged.

@Keavon
Copy link
Member Author

Keavon commented Jul 15, 2021

Some additional features for this one: Shift hotkey constraints to a 15° angle, and adding the Ctrl hotkey locks to that particular constraint angle no matter where you move your mouse after. But let's merge the basic feature before the modifier keys. Also the Ctrl hotkey on its own causes it to snap to the grid, although we don't have a grid yet so don't bother with that yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants