Skip to content

Show working color modifications in the frontend #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TrueDoctor opened this issue May 31, 2021 · 14 comments
Closed

Show working color modifications in the frontend #164

TrueDoctor opened this issue May 31, 2021 · 14 comments
Assignees
Labels
Good First Issue Good for newcomers Web Involves web programming (TypeScript, Svelte, CSS)
Milestone

Comments

@TrueDoctor
Copy link
Member

TrueDoctor commented May 31, 2021

Currently ToolMessage::SwapColors and ToolMessage::ResetColors don't inform the frontend of their changes.

Todo:

  • Add a FrontendMessage::UpdateWorkingColors(primary, secondary)
  • emit that message in the tool_message_handler.rs
  • add the message type to client/web/src/response-handlers.ts
  • register a listener for the message in Document.vue
  • modify the working colors accordingly

Test cases:

  • use the keyboard shortcut X to check the colors have been swapped
  • click the swap and reset buttons below your color picker swatches

Comeplexity: 1
Involves: Editor (Rust), Frontend (Javascript)

@TrueDoctor TrueDoctor added this to the Sprint 4 (current) milestone May 31, 2021
@Keavon Keavon added Rust Web Involves web programming (TypeScript, Svelte, CSS) labels Jun 10, 2021
@akshay1992kalbhor
Copy link
Contributor

Can I try this?

@Keavon
Copy link
Member

Keavon commented Jun 12, 2021

Absolutely! True Doctor assigned you to it. Post a PR (even if it's a draft PR) and we can also add the In-Progress tag to this issue for you also.

@TrueDoctor
Copy link
Member Author

Yes I think this one should suit you really well, please let me know when you have questions and I'll be happy to guide you through

@akshay1992kalbhor
Copy link
Contributor

I am a little intimidated now that I could not finish the last one, but the only way is through so going to try this one. Can you please give me deadline for this? Deadlines really help me work :)

@Keavon
Copy link
Member

Keavon commented Jun 12, 2021

The sprint ends today/tomorrow (the 12th, whichever day that is for your time zone) at 16:00 UTC when we present for the Rust Gamedev Meetup, so if you have time to get your PR merged by then, it'll be checked off the Sprint 4 list.

Otherwise it will be bumped to Sprint 5 and hopefully be one of the first fixes completed for that sprint.

@akshay1992kalbhor
Copy link
Contributor

OK that should help

@TrueDoctor
Copy link
Member Author

I am a little intimidated now that I could not finish the last one, but the only way is through so going to try this one. Can you please give me deadline for this? Deadlines really help me work :)

I can also offer pair programming if you have time

@TrueDoctor
Copy link
Member Author

We do kinda have a bad track record with the complexity we assign to issues and what it actually takes to implement the feature but in this case I am pretty certain that there shouldn't be any unexpected obstacles

@akshay1992kalbhor
Copy link
Contributor

I am a little intimidated now that I could not finish the last one, but the only way is through so going to try this one. Can you please give me deadline for this? Deadlines really help me work :)

I can also offer pair programming if you have time

I am definitely interested. How would that work?

@TrueDoctor
Copy link
Member Author

I am a little intimidated now that I could not finish the last one, but the only way is through so going to try this one. Can you please give me deadline for this? Deadlines really help me work :)

I can also offer pair programming if you have time

I am definitely interested. How would that work?

We get on the graphite discord, you start a screen share and I can help guide you through

@akshay1992kalbhor
Copy link
Contributor

Cool. I will need sometime to read through the code and figure out what I am dealing with. When do you want to do it?

@TrueDoctor
Copy link
Member Author

Whenever you have time. I have a few things scheduled for today but they will probably happen a bit later.
You should not need to read too much code beforehand but you are of course always welcome to do so. Ideally just ping me on discord when you are ready

@akshay1992kalbhor
Copy link
Contributor

OK

@Keavon
Copy link
Member

Keavon commented Jun 12, 2021

Closed by #180

@Keavon Keavon closed this as completed Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers Web Involves web programming (TypeScript, Svelte, CSS)
Projects
None yet
Development

No branches or pull requests

3 participants