-
-
Notifications
You must be signed in to change notification settings - Fork 579
Create a warning that Safari is unsupported #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Are you looking for a solution with a proper modal dialog (which for example contains a link to download a supported browser) or would something like this suffice? if (!("BigInt64Array" in window)) {
alert("Unfortunately your browser does not support the BigInt64Array API. To be able to use Graphite please use a supported browser such as Mozilla Firefox, Google Chrome or Microsoft Edge.");
} |
It is ideally better to avoid using the |
I'll try to implement this. |
Thank you for the feature, that was an awesomely fast turnaround and it's nice and polished. Would you like some suggestions for next things you can tackle? Is your background in web, or do you also know some Rust? |
Yeah it would be great if you could recomend a next task for me to tackle 😄. I do know some Rust, so I feel I should be able to do a Rust or a Rust/Web task. |
@tillarnold Splendid! It's especially great to have someone versed in both parts of the stack because a formidable percentage of all our tasks require touching frontend and backend in some capacity. I've picked out a few relevant possibilities for you which are ready to grab off the shelf. They're ordered from lesser to greater complexity:
Feel free to ask more details about each issue you're drawn to. I want to comment on the issue you choose and give you additional details and implementation steps so you aren't left guessing. Some will require a bit of design too. |
Create a way to tell the user that their browser is unsupported. Provide justification to avoid pissing people off. The reason is Safari's lack of support for the BigInt64Array API, because Safari is basically today's Internet Explorer.
It would probably be nice to still let the user view the web page even if functionality is broken. Let's do something that hides the page until the user reads and acknowledges the message. Try to implement this entirely in
App.vue
to avoid polluting other parts of the frontend codebase.The text was updated successfully, but these errors were encountered: