Skip to content

Support for closing document tabs #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Keavon opened this issue Jun 14, 2021 · 1 comment · Fixed by #215
Closed

Support for closing document tabs #211

Keavon opened this issue Jun 14, 2021 · 1 comment · Fixed by #215
Assignees
Labels
Web Involves web programming (TypeScript, Svelte, CSS)
Milestone

Comments

@Keavon
Copy link
Member

Keavon commented Jun 14, 2021

Click the X button in a tab to close it. Also CtrlW closes the current tab (warning: you can't test this yet, it'll close your browser tab also). This needs a confirmation to prevent loss of work. It also needs to handle what happens when all tabs are closed, perhaps for now that should work by automatically creating a new tab after closing the last tab. This feature might require the switch from document tab indexes to IDs in order to prevent the mutation of tab ordering from causing bugs and headaches.

@Keavon Keavon added Feature Web Involves web programming (TypeScript, Svelte, CSS) labels Jun 14, 2021
@Keavon Keavon added this to the Sprint 6 (upcoming) milestone Jun 14, 2021
@akshay1992kalbhor
Copy link
Contributor

akshay1992kalbhor commented Jun 15, 2021

I am going to. have a go at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Involves web programming (TypeScript, Svelte, CSS)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants