Skip to content

Extend welcome screen button click area to labels #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brunosxs opened this issue Jul 24, 2022 · 1 comment
Closed

Extend welcome screen button click area to labels #738

brunosxs opened this issue Jul 24, 2022 · 1 comment
Assignees
Labels
Paper Cut A small UX annoyance we should strive to improve Web Involves web programming (TypeScript, Svelte, CSS)
Milestone

Comments

@brunosxs
Copy link

brunosxs commented Jul 24, 2022

This requires adding icon support to the TextButton widget Vue component so it fits the UI spec:

image

Then possibly applying special CSS in Panel.vue to remove the gray background so it appears more like it does right now.


Original Issue:

Just started using graphite and came into the realization that it should be clear what is clickable. I thought that this was a button:
image

Instead, just the icon is clickable.
Seeing the colon later made me realize it was just explaning the shortcut, it is still bad because the icon and the label feel like a separate entity from the shortcut label. Also, the icon is very small, not really optimal for touchscreens which Graphite is also targetting.
I don't know if the project has ui guidelines as of now (I found a miro board on the user-interface channel in discord but had no access), do we?

@Keavon
Copy link
Member

Keavon commented Jul 24, 2022

Thanks for your feedback on that! I wanted to make those part of the button but it would add some complexity and I decided against doing that initially, but with your suggestion, that's definitely worth changing sooner than later. One more thing to mention is that we will need to feed this layout from the Rust backend so it can provide the keyboard shortcut correctly based on the user's OS (#206).

Increasing the icon size, although it might help with touchscreens, would deviate from the UI spec. For touchscreens, we'll probably want to just increase the entire UI size, which will be a setting in the future configuration panel.

The UI spec is, currently, just an Adobe XD file I have on my computer. Any Miro board you may have found is old and never had anything on it. I have plans to port that content into some more formal UI documentation that will be part of the design section of the upcoming docs portal. Then we'll eventually port it over to a Graphite file once the app is up to the task of doing UI mockups.

@Keavon Keavon added Blocked Web Involves web programming (TypeScript, Svelte, CSS) Paper Cut A small UX annoyance we should strive to improve labels Jul 24, 2022
@Keavon Keavon added this to the Sprint 17 (ongoing) milestone Jul 24, 2022
@Keavon Keavon changed the title Buttons on start screen should be better telegraphed Extend welcome screen button click area to labels Jul 28, 2022
@Keavon Keavon added Available and removed Blocked labels Jul 28, 2022
@Keavon Keavon closed this as completed in 9f4a241 Aug 8, 2022
@Keavon Keavon removed the Available label Aug 8, 2022
@Keavon Keavon self-assigned this Aug 8, 2022
@0HyperCube 0HyperCube moved this to Completed This Sprint in Task Board Mar 18, 2023
Keavon added a commit that referenced this issue Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paper Cut A small UX annoyance we should strive to improve Web Involves web programming (TypeScript, Svelte, CSS)
Projects
Archived in project
Development

No branches or pull requests

2 participants