Update Imaginate to output bitmap data to the graph via Image Frame node #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
5cf2b8d
|
| Status: | ⚡️ Build in progress... |
|
This seems to be crashing when I import an image (dragging in a PNG file to the viewport). Are you seeing that on your end? |
TrueDoctor
force-pushed
the
image-wrapper-node
branch
from
654269d to
817bd70
Compare
Keavon
force-pushed
the
image-wrapper-node
branch
2 times, most recently
from
584bd1c to
37dcd3f
Compare
* Add transform input to imaginate node * Force the resolution to be edited with no transform * Add transform to imaginate generation * Fix compilation --------- Co-authored-by: Keavon Chambers <[email protected]>
Keavon
force-pushed
the
image-wrapper-node
branch
from
2d97fed to
bcc1a51
Compare
Keavon
changed the title
Keavon
approved these changes
Feb 11, 2023
Keavon
added a commit
that referenced
this pull request
Jul 30, 2023
…ode (#1001) * Multiple node outputs * Add new nodes * gcore use std by default to allow for testing * Allow multiple node outputs * Multiple outputs to frontend * Add ImageFrameNode to node registry * Minor cleanup * Basic transform implementation * Add some logging to image encoding * Fix ImageFrameNode * Add transform input to Imaginate node (#1014) * Add transform input to imaginate node * Force the resolution to be edited with no transform * Add transform to imaginate generation * Fix compilation --------- Co-authored-by: Keavon Chambers <[email protected]> * Add labels to node outputs * Fix seed; disable mask when transform is disconnected; add Imaginate tooltips * Rename 'Input Multiple' node to 'Input' * Code review * Replicate to Svelte * Show only the primary input chain in the Properties panel --------- Co-authored-by: Dennis Kobert <[email protected]> Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #992
The bulk of this PR involves allowing nodes to have multiple outputs. This required some frontend Vue modifications as well as some work with the backend, ensuring all node inputs and network outputs have an index. A document graph rewriting step called
duplicate_outputswas added to flatten the multiple outputs.The node graph now outputs an ImageFrame struct that contains the image data and a transform. Further information can be easily added. The transform is the local transform of the layer, and the resulting transform is applied to the layer. This means that if you disconnect the transform, the layer will resize to have an identity transform.
Modifications to the imaginate tool have not yet been added.