Skip to content

Fix viewport navigation performance by caching graph compilations #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

TrueDoctor
Copy link
Member

@TrueDoctor TrueDoctor commented Nov 26, 2023

Only recompile the graph and update thumbnails if the graph has actually changed. (Future work: only send just the thumbnails that actually changed instead of resending all of them.)

@Keavon
Copy link
Member

Keavon commented Nov 26, 2023

!build-profiling

Copy link

📦 Build Complete for 8f47485
https://71580510.graphite.pages.dev

@TrueDoctor TrueDoctor marked this pull request as ready for review November 26, 2023 14:10
@TrueDoctor TrueDoctor enabled auto-merge (squash) November 26, 2023 14:15
@Keavon Keavon changed the title Cache graph compilations Fix viewport navigation performance by caching graph compilations Nov 26, 2023
@Keavon Keavon disabled auto-merge November 26, 2023 14:16
@Keavon Keavon enabled auto-merge (squash) November 26, 2023 14:16
@Keavon Keavon merged commit 661f613 into master Nov 26, 2023
@Keavon Keavon deleted the compile-cache branch November 26, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants