Skip to content

Fix how transforms work with footprints and remove a redundant transforms field #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 3, 2023

Conversation

TrueDoctor
Copy link
Member

@TrueDoctor TrueDoctor commented Dec 3, 2023

Part of #1394

Cleans up many console warnings and fixes a few other transforms-related issues.

Note that loading the demo artwork from the main branch does not work as the artwork needed to be updated to work with the new artboard node (to support moving the contents when the artboard is moved). You can try loading the local files if you want.

@Keavon
Copy link
Member

Keavon commented Dec 3, 2023

@0HyperCube @TrueDoctor Great work fixing all these transform issues! We still have one regression that I notice: folders now have no bounds so clicking them shows just the pivot and no rectangle for the transform cage.

@0HyperCube
Copy link
Member

@Keavon That is not a regression as it is the case on the main branch.

@Keavon
Copy link
Member

Keavon commented Dec 3, 2023

Oh I didn't realize that! I'll make a note of it in the tracking issue then.

@Keavon
Copy link
Member

Keavon commented Dec 3, 2023

@TrueDoctor I recall seeing this before we jumped off the call earlier but I wasn't sure if it had been fixed in the last minute once things came together or not. It appears to still be a thing though:

image

Just make a new document, draw a rectangle, and drag it with the Select tool.

@Keavon Keavon changed the title Reduce console spam Fix how transforms work with footprints and remove a redundant transform field Dec 3, 2023
@Keavon Keavon changed the title Fix how transforms work with footprints and remove a redundant transform field Fix how transforms work with footprints and remove a redundant transforms field Dec 3, 2023
Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great collaborative effort on this @0HyperCube and @TrueDoctor! Good to see the code simplified and bugs solved in the end.

@Keavon Keavon merged commit b7fe38c into master Dec 3, 2023
@Keavon Keavon deleted the reduce-console-spam branch December 3, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants