-
-
Notifications
You must be signed in to change notification settings - Fork 578
Fix how transforms work with footprints and remove a redundant transforms field #1484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
203c687
to
2d96eed
Compare
@0HyperCube @TrueDoctor Great work fixing all these transform issues! We still have one regression that I notice: folders now have no bounds so clicking them shows just the pivot and no rectangle for the transform cage. |
@Keavon That is not a regression as it is the case on the main branch. |
Oh I didn't realize that! I'll make a note of it in the tracking issue then. |
@TrueDoctor I recall seeing this before we jumped off the call earlier but I wasn't sure if it had been fixed in the last minute once things came together or not. It appears to still be a thing though: Just make a new document, draw a rectangle, and drag it with the Select tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great collaborative effort on this @0HyperCube and @TrueDoctor! Good to see the code simplified and bugs solved in the end.
Part of #1394
Cleans up many console warnings and fixes a few other transforms-related issues.
Note that loading the demo artwork from the main branch does not work as the artwork needed to be updated to work with the new artboard node (to support moving the contents when the artboard is moved). You can try loading the local files if you want.