Skip to content

Serve the demo artwork in each build #1494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Serve the demo artwork in each build #1494

merged 4 commits into from
Dec 11, 2023

Conversation

0HyperCube
Copy link
Member

@0HyperCube 0HyperCube commented Dec 9, 2023

Instead of importing the demo artwork from a GitHub link, which means the dev has to share the same file used by prod even though they aren't compatible, now we copy the demo artwork files into each deployed build's distributables.

@Keavon
Copy link
Member

Keavon commented Dec 10, 2023

Temporarily blocked on nguyenbatranvan/vite-multiple-assets#8 which is an issue with a plugin that can allow us to have multiple public/assets folders. That seems cleaner because I'd ideally still like to define as much as possible purely in Rust so there are a few dependencies on the JS code. But if that isn't resolved in a few days, your current approach is a solid one too so we'll roll with that. But in the next few days I'll see if things change in that issue linked above.

@Keavon Keavon changed the title Serve local demo artwork Serve the demo artwork in each build Dec 11, 2023
@Keavon Keavon merged commit af4c793 into master Dec 11, 2023
@Keavon Keavon deleted the local-demo-artwork branch December 11, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants