Add tests to the Ellipse, Artboard, and Fill tools #2181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
force-pushed
the
master
branch
2 times, most recently
from
7465fad to
ab724d8
Compare
0HyperCube
force-pushed
the
improve-testing-utils
branch
from
5e0e1f5 to
ab81a48
Compare
0HyperCube
force-pushed
the
improve-testing-utils
branch
from
ab81a48 to
dfc3483
Compare
0HyperCube
force-pushed
the
improve-testing-utils
branch
2 times, most recently
from
9a10691 to
e5ec3e0
Compare
0HyperCube
force-pushed
the
improve-testing-utils
branch
from
e10381c to
8798d3f
Compare
Keavon
force-pushed
the
improve-testing-utils
branch
from
8798d3f to
e73b514
Compare
0HyperCube
force-pushed
the
improve-testing-utils
branch
from
e73b514 to
932248d
Compare
0HyperCube
changed the title
Keavon
approved these changes
Mar 7, 2025
Keavon
changed the title
Is that accurate or did that get referenced in the wrong ticket? I didn't see changes relating to that when I read the diff. |
|
@Keavon it does provide a system where an identifier can be used instead of an index to access an input (see changes in this PR to the codegen.rs). However I have only used these as part of the new tests and haven't yet modified other instances of the indices. An example of getting the input from an instrumented graph: instrumented.grab_protonode_input::<ellipse::RadiusXInput>(&vec![ellipse_node], &editor.runtime).unwrap() |
|
I see, that's cool! Looking forward to rolling that out throughout the rest of the code. I like that syntax. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A not very good attempt at #1490
Closes #2146 because it broke the test.