Skip to content

Instance tables refactor part 3: flatten ImageFrame<P> in lieu of Image<P> #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 2, 2025

Conversation

Keavon
Copy link
Member

@Keavon Keavon commented Feb 3, 2025

Part 3, partly closes #1834.

Flattens the one-field ImageFrame<P> struct, removing it to put Image<P> in its place.

This PR is based on top of #2249. The first commit in the chain of this PR's changes is b36f57f. This PR is blocked on that PR being merged first.

@Keavon
Copy link
Member Author

Keavon commented Mar 2, 2025

Merging with one known issue:

capture

This occurs while upgrading a previous document that contains Brush tool strokes. It doesn't seem to actually affect things, except for the fact that it alters the bounding box of the brush strokes to extend to the origin. After saving and reloading the upgraded document, that remains true but the console error doesn't return. Since brushes are not fully supported and usage is likely to be rare, I'm not going to investigate and try to fix this.

@Keavon Keavon force-pushed the instance-tables-pt3 branch from cb1dbdf to 39cf18d Compare March 2, 2025 09:31
@Keavon Keavon merged commit 9ae6562 into master Mar 2, 2025
4 checks passed
@Keavon Keavon deleted the instance-tables-pt3 branch March 2, 2025 10:09
Keavon added a commit that referenced this pull request Mar 6, 2025
…ge<P> (#2256)

* Remove ImageFrame<T> by flattening it into Image<T>

* Rename TextureFrame to ImageTexture

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Instances tables
1 participant