Remove partialeq for layers #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
approved these changes
Jun 29, 2021
Keavon
pushed a commit
that referenced
this pull request
Jul 4, 2021
Keavon
pushed a commit
that referenced
this pull request
Jul 4, 2021
Keavon
pushed a commit
that referenced
this pull request
Jun 16, 2022
# Conflicts: # Cargo.lock # core/document/Cargo.toml
Keavon
pushed a commit
that referenced
this pull request
Jun 16, 2022
Keavon
pushed a commit
that referenced
this pull request
Jul 30, 2023
# Conflicts: # Cargo.lock # core/document/Cargo.toml
Keavon
pushed a commit
that referenced
this pull request
Jul 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Layers should not need to be compared directly, but rather through their path / id, which is both quicker and more accurate and also is already done throughout the codebase. This PR just removes unnecessary
#[derives and also has the added benefit of removing our dependency on a forked version of kurbo.This change is