Skip to content

Frontend refactor to move response handler, key input handling, and more into new utilities folder #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

Keavon
Copy link
Member

@Keavon Keavon commented Jul 14, 2021

Part of #124


This change is Reviewable

@Keavon Keavon requested a review from TrueDoctor July 14, 2021 11:43
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 14, 2021

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 32ea45a
Status: ✅  Deploy successful!
Preview URL: https://33658343.graphite-master.pages.dev

View logs

@Keavon Keavon force-pushed the refactor-utilities branch from 96d3732 to 5af0d2b Compare July 14, 2021 12:08
Copy link
Member

@TrueDoctor TrueDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Keavon)


client/web/src/utilities/input.ts, line 9 at r1 (raw file):

	// Don't redirect a fullscreen request
	if (e.key.toLowerCase() === "f11") return false;

f5 should not be redirected either

@ajweeks
Copy link
Contributor

ajweeks commented Jul 14, 2021

Reviewed 14 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Keavon)

client/web/src/utilities/input.ts, line 9 at r1 (raw file):

	// Don't redirect a fullscreen request
	if (e.key.toLowerCase() === "f11") return false;

f5 should not be redirected either

While you're at it, you might also want to ignore Control+Shift+I and Control+Shift+J:
image
https://developer.chrome.com/docs/devtools/shortcuts/

@Keavon Keavon force-pushed the refactor-utilities branch from 5af0d2b to 32ea45a Compare July 14, 2021 21:23
Copy link
Member Author

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion (waiting on @TrueDoctor)


client/web/src/utilities/input.ts, line 9 at r1 (raw file):

Previously, ajweeks wrote…

While you're at it, you might also want to ignore Control+Shift+I and Control+Shift+J:
image
https://developer.chrome.com/docs/devtools/shortcuts/

Done.

@Keavon Keavon merged commit 7261527 into master Jul 14, 2021
@Keavon Keavon deleted the refactor-utilities branch July 14, 2021 21:31
Keavon added a commit that referenced this pull request Jun 16, 2022
Keavon added a commit that referenced this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants