-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Spacing type radio button for repeat and circular repeat node #2674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Spacing type radio button for repeat and circular repeat node #2674
Conversation
|
!build |
|
|
Finally got to code review, sorry it's taken a while. I was busy doing a sizable refactor to how the vector nodes handle their repeat transforms. This affected the two nodes you've worked on here, so I just synced up your branch and resolved the merge conflicts. However, I commented out the Circular Repeat changes which require a bit more thought to get working, and I hope you can take it from here after the following feedback which pertains to my observations before I synced with master using the build link, as you left the code last, in the comment above. Repeat node:
Circular Repeat node:
Other notes:
Thank you, and it's nice to see this coming along! |
|
Macros split into their own PR: #2706 |
34dced3 to
5cacab2
Compare
a969f79 to
8aafcb6
Compare
|
I have force pushed this branch to move it to a new base. Ensure you have the branch checked out. Then run |
316a737 to
532e913
Compare
ec51271 to
e025103
Compare
Closes #2551
Spacingradio parameter toRepeatnode, containingSpan,Envelope,Pitch, andGapoptions for spacing. See issue for how they must be spaced.Angle Pitchfloat parameter andSpacingradio parameter forCircular Repeatnode. TheSpanoption uses the calculations which already existed, thePitchoption rotates the next instance around the radius of the imaginary circle according to theAngle Pitchparameter and places the shape there.unitmacro attribute. Givenstringparameter is displayed as a unit type for the parameter.stepmacro attribute. Given integer parameter is used as the step value for the parameter (ex. the arrow buttons on a number input increment/decrement bystepamount).display_decimal_placesmacro attribute. Given positive integer parameter is used to know how many decimal places to display for the number input if they are not 0.Usage for macros: