Remove the serde feature and instead just always require it
#2737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
changed the title
serde, always require it instead serde, always require it instead
Keavon
force-pushed
the
remove-serde-feature
branch
from
94727cb to
7e034a8
Compare
Keavon
force-pushed
the
workspace-dependencies
branch
from
da125b8 to
0c0551f
Compare
TrueDoctor
approved these changes
Jun 21, 2025
Keavon
force-pushed
the
workspace-dependencies
branch
from
0c0551f to
cb8a6c3
Compare
Keavon
force-pushed
the
remove-serde-feature
branch
from
7e034a8 to
95fff0b
Compare
Keavon
changed the title
serde, always require it instead serde feature and instead just always require it
Keavon
changed the title
serde feature and instead just always require itserde feature and instead just always require it
urisinger
pushed a commit
to urisinger/Graphite
that referenced
this pull request
Jul 15, 2025
…teEditor#2737) workspace: remove feature `serde`, always require it instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2736
Everything needs serde anyway