-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Shaders: add gcore-shaders and make graster-nodes no-std
#2925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be75a07 to
ad17f8e
Compare
78d75fe to
ff600c4
Compare
ad17f8e to
cc2b788
Compare
ff600c4 to
00b1e98
Compare
00b1e98 to
343cbc5
Compare
343cbc5 to
4f1fa32
Compare
Member
|
I agree that it makes sense to have an actual no_std crate and we should have ci testing to confirm that it always builds without the std feature. We can still slim down gcore over time and let you focus on implementing gpu acceleration |
TrueDoctor
approved these changes
Jul 25, 2025
Collaborator
Author
|
There won't be any CI for the moment, but as soon as shaders work you need to compile shaders to compile graphite, and you'll have implicit CI for it being no_std. |
4f1fa32 to
7470d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2924
gcoreintogcore-shadersand reexports them ingcoreChoiceTypeStaticfromregistryto a separatechoice_typemodgraster-nodesbe no-std with anstdfeature to mask out node codeSo you can now build
graster-nodesin a no-std environment, a prerequisite for shaders:cargo build -p graphene-raster-nodes --no-default-featuresWhy
gcore-shadersSimply put, there is still way too much stuff in
gcorefor it to become a no-std crate. So we either:gcore-shaderscrate that contains all of theno-stdstuff, with very little masking neededgcoreinto no_std and move everything out of itgnode, which would end up containing all the node definitions, registry and the like anyway. Stuff could get moved out from there later.gcore, and you will forget to place the masks and break the build. Which is why I strongly prefer a separate crate.