MVP eyedropper tool for fill colors #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tasks from upcoming sprints are always on the table! I was also debating with myself if we should even include it in 6 or 7. Thanks for grabbing it. |
Keavon
reviewed
Jul 24, 2021
Deploying with
|
| Latest commit: |
fb878bd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a38ba3b3.graphite-master.pages.dev |
Keavon
approved these changes
Jul 24, 2021
|
Can you please add right click mapping to the secondary color? So left click samples into the primary color while right click samples into the secondary color. |
Keavon
pushed a commit
that referenced
this pull request
Jun 16, 2022
* Implement eyedropper for layer fill colors * Add shortcut for eyedropper * Add right mouse sampling for secondary color
Keavon
pushed a commit
that referenced
this pull request
Jul 30, 2023
* Implement eyedropper for layer fill colors * Add shortcut for eyedropper * Add right mouse sampling for secondary color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #303.
This was marked for Sprint 7, but I realized this MVP would be a quick and useful addition.
FillandStrokeLmb => MouseDowninput mapping for the eyedropper toolCaveat: The color update is implemented using
FrontendMessage::UpdateWorkingColorsas opposed toSelectPrimaryColor. That is because using the former doesn't update colors on the frontend. AddingUpdateWorkingColorsto the handler forSelectPrimaryColorcauses an unresponsive infinite-loop on the frontend. This is becauseSwatchPairInputregisters a response handler forResponseType.UpdateWorkingColorsbut alsowatchesprimaryColorandsecondaryColor, mapping changes toSwatchPairInput.update{Primary | Secondary}Color. Those two functions each the respective WASM functions, which in turn dispatch the color selection messages, causing an infinite loop.In the future, I think this infinite loop should be avoided by removing the
watches and instead add callbacks toColorPicker. We should only be dispatching theSelect...Colormessages when the frontend (i.e. the user) updates the colors. In fact, as it currently is, the response handler forUpdateWorkingColorsalways dispatches redundant calls toSelectPrimaryColorandSelectSecondaryColor.I could implement that fix, but I think we should leave it for another PR to work out details.
This change is