Skip to content

Fix new nodes being added in the wrong place near graph edges#4211

Merged
Keavon merged 1 commit into
masterfrom
fix-node-insertion-coords
Jun 8, 2026
Merged

Fix new nodes being added in the wrong place near graph edges#4211
Keavon merged 1 commit into
masterfrom
fix-node-insertion-coords

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Jun 8, 2026

Fixes #4205

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request decouples the node creation coordinates from the context menu display coordinates. It introduces a new 'node_creation_coordinates' field to 'ContextMenuInformation' to store the original click point, ensuring that newly created nodes are placed at the exact click location even if the context menu itself is shifted to fit on-screen. The frontend 'Graph.svelte' has been updated to use these new coordinates when creating a node. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon merged commit 7a6e4f6 into master Jun 8, 2026
10 checks passed
@Keavon Keavon deleted the fix-node-insertion-coords branch June 8, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New nodes added in the wrong place

1 participant