Skip to content

Remake Eyedropper tool to sample pixel colors from viewport canvas #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 21, 2022
Merged

Remake Eyedropper tool to sample pixel colors from viewport canvas #801

merged 5 commits into from
Oct 21, 2022

Conversation

Keavon
Copy link
Member

@Keavon Keavon commented Oct 20, 2022 •
edited
Loading

Closes #545

eyedropper_demo.mp4

@Keavon Keavon requested review from 0HyperCube and otdavies October 20, 2022 23:46
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 20, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81a1adb
Status: ✅  Deploy successful!
Preview URL: https://46e8fcb1.graphite-master.pages.dev
Branch Preview URL: https://eyedropper-pixel-picking.graphite-master.pages.dev

View logs

otdavies
otdavies approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@otdavies otdavies left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed these changes, they look good to me, nothing jumped out at me as overly concerning. My only sticking point was your note regarding unusual behavior with strange DPI, but that can likely be resolved in a later PR. Looks good, operates great.

@Keavon
Copy link
Member Author

Keavon commented Oct 21, 2022 •
edited
Loading

  • Add an option to hit the Escape key to cancel the action of setting a color.
  • Remove the bulging active ring. Set an outer drop shadow.

@Keavon Keavon merged commit f2db20f into master Oct 21, 2022
@Keavon Keavon deleted the eyedropper-pixel-picking branch October 21, 2022 08:50
Keavon added a commit that referenced this pull request Jul 30, 2023
@Keavon
Remake Eyedropper tool to sample pixel colors from viewport canvas (#801
58a53a9 
)

* Remake Eyedropper tool to sample pixel colors from viewport canvas

* Bug fixes

* Reorder export buttons

* Remove the larger primary/secondary ring

* Add aborting with Escape
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otdavies otdavies otdavies approved these changes

@0HyperCube 0HyperCube Awaiting requested review from 0HyperCube

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pixel-based color sampling for the Eyedropper tool
2 participants
@Keavon @otdavies