Skip to content

Node graph improvements #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 17, 2022
Merged

Node graph improvements #855

merged 16 commits into from
Nov 17, 2022

Conversation

0HyperCube
Copy link
Member

@0HyperCube 0HyperCube commented Nov 14, 2022

Closes #851

  • Linking nodes doesn't crash
  • Input and Output node (although it doesn't really care if you actually use the input node as long as you have a node that accepts a network)
  • Brighten / Grey-scale and Hue Shift nodes that work on images.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Nov 15, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5cd0932
Status: ✅  Deploy successful!
Preview URL: https://3e599618.graphite-master.pages.dev
Branch Preview URL: https://node-graph-improvements.graphite-master.pages.dev

View logs

@Keavon Keavon force-pushed the node-graph-improvements branch from eee27a2 to 9a80538 Compare November 17, 2022 20:51
@Keavon Keavon force-pushed the node-graph-improvements branch from 9a80538 to 77ad6a3 Compare November 17, 2022 20:53
@0HyperCube 0HyperCube marked this pull request as ready for review November 17, 2022 21:16
@Keavon Keavon merged commit 6cd0dbd into master Nov 17, 2022
@Keavon Keavon deleted the node-graph-improvements branch November 17, 2022 23:36
@Keavon Keavon mentioned this pull request Dec 12, 2022
26 tasks
Keavon added a commit that referenced this pull request Jul 30, 2023
* Selecting multiple nodes

* Improve logs

* Log bad types in dyn any

* Add (broken) node links

* New topological sort

* Fix reorder ids function

* Input and output node

* Add nodes that operate on images

* Fixups

* Show node parameters together with layer properties

* New nodes don't crash editor

* Fix tests

* Node positions backend

* Generate node graph on value change

* Add expose input message

* Fix tests

Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MVP improvements for the rudimentary node graph
2 participants