Skip to content

Add preview and disable buttons for nodes #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 25, 2022
Merged

Conversation

0HyperCube
Copy link
Member

@0HyperCube 0HyperCube commented Dec 23, 2022

Closes #881

The preview and disable buttons show in the right of the bar above the node graph. They hide if no nodes are selected.

Disabling a node converts it to an identity node and setting a preview will set it as output. The output is shown with a blue outline and disabled nodes are greyed out.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 23, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3769bb1
Status: ✅  Deploy successful!
Preview URL: https://2673b426.graphite.pages.dev
Branch Preview URL: https://preview-and-disable.graphite.pages.dev

View logs

@Keavon
Copy link
Member

Keavon commented Dec 25, 2022

Great work. I've added some followup UX improvement requests in #881.

@Keavon Keavon changed the title Add preview and disable button Add preview and disable buttons for nodes Dec 25, 2022
@Keavon Keavon merged commit 16dae0f into master Dec 25, 2022
@Keavon Keavon deleted the preview-and-disable branch December 25, 2022 10:28
@Keavon Keavon mentioned this pull request Dec 25, 2022
13 tasks
Keavon added a commit that referenced this pull request Feb 8, 2023
* Add preview and disable button

* Fix tests

Co-authored-by: Keavon Chambers <[email protected]>
Keavon added a commit that referenced this pull request Jul 30, 2023
* Add preview and disable button

* Fix tests

Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node graph editing UX improvements
2 participants