Skip to content

Node 'Disable' and 'Preview' UX improvements #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Conversation

0HyperCube
Copy link
Member

Closes #881

  • Don't show the Disable button for the Input and Output nodes.
  • Alt-click a node to preview it, or disable its preview
  • CtrlH to hide a node, and rename the button "Hide" and "Show"
  • Explain those keyboard shortcuts in the two buttons' tooltips

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 27, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a2d599
Status: ✅  Deploy successful!
Preview URL: https://2412ae48.graphite.pages.dev
Branch Preview URL: https://disable-ux-improvements.graphite.pages.dev

View logs

Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and feels great, just this little string adjustment. Then good to merge, thanks!

@Keavon Keavon changed the title Disable and preview UX improvements Node 'Disable' and 'Preview' UX improvements Dec 28, 2022
@Keavon Keavon merged commit 609ab32 into master Dec 28, 2022
@Keavon Keavon deleted the disable-ux-improvements branch December 28, 2022 19:38
@Keavon Keavon mentioned this pull request Jan 15, 2023
13 tasks
Keavon added a commit that referenced this pull request Feb 8, 2023
* Don't allow disabling input or output nodes

* Shortcuts to show and preview node

* Update preview tooltip and label

Co-authored-by: Keavon Chambers <[email protected]>
Keavon added a commit that referenced this pull request Jul 30, 2023
* Don't allow disabling input or output nodes

* Shortcuts to show and preview node

* Update preview tooltip and label

Co-authored-by: Keavon Chambers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node graph editing UX improvements
2 participants