Repository navigation
Budget the authoritative HTTP policy decision at zero growth - #591
Merged
Merged
Conversation
Second step of the reviewed harness-then-budget transition for the http_policy target (#571 landed the harness). microbench-budget.json moves to schema 2: it approves the harness digest in kernel_harness_sha256 (computed from the git blob, as microbench.py does) and adds a zero-growth http_policy entry. This PR runs in the proposed state against its schema-1 base; every later comparison whose base carries schema 2 enforces the budget. The benchmark doc gains a section on the target, its adoption states and the per-revision build.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 of 10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #437. This is the budget step of the two-step transition; #571 landed the harness.
microbench-budget.jsonmoves to schema 2 and approves thehttp_policyharness digestf10830a1…. That digest is computed from the git blob through microbench.py's own_kernel_harness(); the same method reproduces the already-approved pure-path digest0e005f79…. A zero-growthhttp_policytarget is added.validate_budgetaccepts it, andkernel_policy(main budget, this budget)returnsproposed. Once this merges, every comparison whose base carries schema 2 isenforced.Local:
test_microbench.pyandtest_microbench_process.pypass.